RTL8168 Implementation #1652
RTL8168 Implementation #1652
Conversation
valentinbreiz
added
Area: Networking
Arawn-Davies
requested review from
quajak and
Arawn-Davies
and removed request for
Arawn-Davies
| /// </summary> | ||
| /// <param name="port"></param> | ||
| /// <returns></returns> | ||
| public static byte InB(ushort port) |
There was a problem hiding this comment.
I prefer we go with the same approach we have for other drivers as well, which is that we define all the the IOPorts we need and then access the one we actually need. For example see
Cosmos/source/Cosmos.Core/IOGroup/ATA.cs
Line 13 in a3d0a07
That approach should be quicker since we arnt constantly creating new objects and less error prone than calculating the port address every time.
|
|
||
| if (((GetMacVersion() & 0x7cf00000) == 0x54100000) || ((GetMacVersion() & 0x7cf00000) == 0x54000000)) | ||
| { | ||
| Console.WriteLine("8168H Detected!"); |
| public bool Reset() | ||
| { | ||
| Ports.OutB((ushort)(BaseAddress + 0x37), 0x10); /* Send the Reset bit to the Command register */ | ||
| while ((Ports.InB((ushort)(BaseAddress + 0x37)) & 0x10) != 0) { } /* Wait for the chip to finish resetting */ |
There was a problem hiding this comment.
Should we have timeout in this method, in which case we return false?
| } | ||
|
|
||
| protected void HandleNetworkInterrupt(ref IRQContext aContext) | ||
| { |
There was a problem hiding this comment.
Are all the Console.WriteLines in this method required? They seem like debug output and should be removable
|
|
||
| Console.WriteLine("NIC IRQ: " + device.InterruptLine); | ||
|
|
||
| var RTL8168Device = new RTL8168(device); |
There was a problem hiding this comment.
How is the device accessible from outside the class? Again I dont like the Console.WriteLines, maybe make the Init(bool aShowOutput) have a toggle for console output?
No description provided.